Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes java doc warnings #36483

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

appiepollo14
Copy link
Contributor

Fixes #29309

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Oct 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 14, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@appiepollo14 appiepollo14 changed the title fixes java doc warnings Fixes java doc warnings Oct 14, 2023
@appiepollo14
Copy link
Contributor Author

@gastaldi how to solve this merge commit blocking?

@gastaldi
Copy link
Contributor

You need to rebase your branch with main before pushing

@gastaldi
Copy link
Contributor

Make sure the following config is set in your environment (you can add --global since they are really useful)

git config pull.rebase true
git config branch.autosetuprebase always

Then, in your branch:

git rebase main

Then you git push -f to your remote branch

@appiepollo14 appiepollo14 force-pushed the feature/fix-java-doc-warning branch from 8c2bc9e to eca33af Compare October 15, 2023 10:45
@appiepollo14 appiepollo14 force-pushed the feature/fix-java-doc-warning branch from eca33af to b8b8ad9 Compare October 15, 2023 10:56
@appiepollo14
Copy link
Contributor Author

Thank you very much, this did solve it!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 15, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 15, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@appiepollo14
Copy link
Contributor Author

Thanks for letting me help on my first contribution to Quarkus. Love the product !!!

@gastaldi gastaldi merged commit f0397be into quarkusio:main Oct 15, 2023
20 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 15, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 15, 2023
@appiepollo14 appiepollo14 deleted the feature/fix-java-doc-warning branch October 15, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javadoc Warnings in the Gradle plugin
2 participants